Fix the Charset values in the SES mailer
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard name is `UTF-8`. The dash-less variant `utf8` does not exist in [the IANA registry](https://www.iana.org/assignments/character-sets/character-sets.xhtml), so it might not be understood by all email clients. I'm thinking that this irregularity could be the cause of <liberapay/liberapay.com#2239>. The [example in boto3's documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ses/client/send_email.html) uses `UTF-8`.
|
Wow. Nice catch. Thank you |
|
Did you accidentally close this instead of merging it? |
|
BTW, I just published a new release (v2.3) with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard name is
UTF-8. The dash-less variantutf8does not exist in the IANA registry, so it might not be understood by all email clients. I'm thinking that this irregularity could be the cause of liberapay/liberapay.com#2239. The example in boto3's documentation usesUTF-8.