Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Swift Argument Parser versions from 1.2.1 to 2.0.0 #799

Merged
merged 2 commits into from
May 5, 2024

Conversation

tonyarnold
Copy link
Contributor

@tonyarnold tonyarnold commented Dec 13, 2023

This lower version number is preventing packages from using SwiftLint and the Swift OpenAPI Generator in the same package.

@tonyarnold
Copy link
Contributor Author

While I'm doing this — would you be willing to consider changing this dependency from upToNextMinor to upToNextMajor?

@jpsim
Copy link
Owner

jpsim commented Dec 14, 2023

While I'm doing this — would you be willing to consider changing this dependency from upToNextMinor to upToNextMajor?

Yes, let's do that but revert back to 1.2 so that if other packages are depending on 1.2.x this change doesn't break them.

@jpsim
Copy link
Owner

jpsim commented Dec 14, 2023

Don't worry about the Bazel test failures, there's been some changes to Bazel that I should adjust for.

@tonyarnold
Copy link
Contributor Author

No problems, I'll do it now. Did you want me to do the same for SWXMLHash?

@jpsim
Copy link
Owner

jpsim commented Dec 14, 2023

Yes please! 🙏

…to SAP 1.2.1

This is preferable to raising the required version.
@tonyarnold
Copy link
Contributor Author

Done in 91d9cd7.

I'll do the same for SwiftLint once there's a tagged release of SourceKitten with these changes in it.

Thanks, JP!

@tonyarnold tonyarnold changed the title Raise the minimum version of Swift Argument Parser to version 1.3.0 Allow Swift Argument Parser versions from 1.2.1 to 2.0.0 Dec 14, 2023
@SimplyDanny
Copy link
Contributor

Can this be merged? Together with a new release, SwiftLint could use 1.3.0 of Swift Argument Parser.

@Sparklydust
Copy link

Hello @SimplyDanny, I wish to have this update available as I cannot use both OpenAPI and SwiftLint.
Is there anything missing that I can help you with if needed?

@revolter
Copy link

revolter commented May 5, 2024

I need this as well 🙏🏻

@jpsim
Copy link
Owner

jpsim commented May 5, 2024

Ill merge and look into the CI failures async.

@jpsim jpsim merged commit 23391c3 into jpsim:main May 5, 2024
9 of 13 checks passed
@revolter
Copy link

revolter commented May 5, 2024

Thank you very much 🙏🏻 Hopefully you have time to push a new release as well, containing this change.

@jpsim
Copy link
Owner

jpsim commented May 5, 2024

0.35.0 was pushed with these changes: https://github.com/jpsim/SourceKitten/releases/tag/0.35.0

@revolter
Copy link

revolter commented May 5, 2024

Continued in realm/SwiftLint#5562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants