Translate C to Swift #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
force-pushed
the
translate-c-to-swift
branch
6 times, most recently
from
e011ca5
to
f945b73
Compare
Migrate the `CMicrophonePitchTracker` C module to a new `ZenPTrack`
Swift module.
When compiling the new module with `-Ounchecked` performance is within
0%-2% of the C version. Without `-Ounchecked` it has a 20%-25% overhead.
```console
$ hyperfine --warmup 30 --runs 50 \
pitchbench-c \
pitchbench-swift-checked \
pitchbench-swift-unchecked
Benchmark 1: ./pitchbench-c
Time (mean ± σ): 391.7 ms ± 0.7 ms [User: 379.3 ms, System: 8.6 ms]
Range (min … max): 390.7 ms … 394.1 ms 50 runs
Benchmark 2: ./pitchbench-swift-checked
Time (mean ± σ): 472.1 ms ± 0.8 ms [User: 459.5 ms, System: 8.9 ms]
Range (min … max): 471.0 ms … 475.8 ms 50 runs
Benchmark 3: ./pitchbench-swift-unchecked
Time (mean ± σ): 391.7 ms ± 0.5 ms [User: 379.5 ms, System: 8.6 ms]
Range (min … max): 390.9 ms … 392.9 ms 50 runs
Summary
'./pitchbench-c' ran
1.00 ± 0.00 times faster than './pitchbench-swift-unchecked'
1.21 ± 0.00 times faster than './pitchbench-swift-checked'
```
`-Ounchecked` breaks Swift's memory safety, but the fact that it's only
enabled in release mode, combined with Swift's additional safety over C
even with that flag, means we're in a safer position than the C code
we're replacing.
jpsim
force-pushed
the
translate-c-to-swift
branch
from
f945b73
to
ddbb50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
CMicrophonePitchTrackerC module to a newZenPTrackSwift module.When compiling the new module with
-Ouncheckedperformance is within 0%-2% of the C version. Without-Ouncheckedit has a 20%-25% overhead.-Ouncheckedbreaks Swift's memory safety, but the fact that it's only enabled in release mode, combined with Swift's additional safety over C even with that flag, I believe means we're in a safer position than the C code we're replacing. I think.