New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p> #45
Comments
Hi @orditeck, Thanks a lot for the PR. One of the reason that I kept it and not is that generated HTML and MarkDown use syntax for
, thus I preferred in editor also to preserve exact styling of margins. But may just work well and also fix the warning. I will merge the PR and check. Thanks a ton 😄
~ Jyoti |
Hello @orditeck, Thinks got little delayed as I was on vacation. But I have to undo the these changes. The reason being that the generated mark-down and HTML use tag thus to keep things consistent I would prefer to use tag in editor also. Plz share your thoughts about it. |
@jpuri I'm sorry but I don't understand why you want to keep the Is there any reason for this? 'cause otherwise the warning will stay. |
@orditeck: WYSIWYG editor typically use for normal text paragraphs and I would not prefer to deviate from it also you can see in output tags are used for paragraphs. Should I go ahead to close this issue ? |
Closing the issue as there is no response. |
Hey @jpuri I think it's fine to use What issues would result from us transitioning from |
@jpuri I reinstall this package and we still get the warning "Warning: validateDOMNesting(...): < div > cannot appear as a descendant of < p >" Red warning color is not good for an application. Please tell us if you pursue to continue using "< p >" instead of < div > Thanks! |
@bonniecool look at her comment right above mine. |
@vhmth thanks! :-D |
Hey @vhmth, @bonniecool: These changes are already in develop and I will release this week. I am trying to slow down little on release cycles and releasing only well tested code. |
The fix has been release in in version |
Sweet! Seems like it works. :-) |
Just started to use this yesterday and getting the "Calling PropTypes validators..." warning. Any help is apprecaited. Thanks |
@bnwan: which version of editor are you using ? |
I'm getting this warning.
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>. See DraftEditorContents > p > ... > DraftEditorBlock > div.
The problem is this
<p>
here https://github.com/jpuri/react-draft-wysiwyg/blob/master/js/src/components/Editor/index.js#L151Pull request coming soon.
The text was updated successfully, but these errors were encountered: