Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Support a promise being returned inside response callback functions #30

Closed
jpwilliams opened this issue Jun 30, 2017 · 2 comments
Closed

Support a promise being returned inside response callback functions #30

jpwilliams opened this issue Jun 30, 2017 · 2 comments
Assignees
@jpwilliams
Labels
⛅ improvement ⛔ onhold
Milestone
2.1.0

Comments

@jpwilliams
Copy link
Owner

No description provided.

@jpwilliams jpwilliams added this to the 2.0.0 milestone Jun 30, 2017
@jpwilliams jpwilliams self-assigned this Jun 30, 2017
@jpwilliams
Copy link
Owner Author

Looks like this is super tricky with our current set-up as we use EventEmitters to apply messages to multiple callbacks, therefore currently have no return data from said callbacks.

This ticket would require me accessing those returned values to ascertain whether or not a Promise had been returned.

Tricksy.

@jpwilliams jpwilliams modified the milestones: 2.1.0, 2.0.0 Jul 3, 2017
jpwilliams added a commit that referenced this issue Aug 2, 2017
@jpwilliams
✨ Potential #30 implementation - returning promises in response callb…
4eb6409 
…acks
jpwilliams added a commit that referenced this issue Aug 2, 2017
@jpwilliams
📋 New examples for endpoint promises for #30
e64199a
@jpwilliams
Copy link
Owner Author

Implemented in Release v2.0.0-beta.12.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jpwilliams jpwilliams

Labels
⛅ improvement ⛔ onhold
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@jpwilliams