Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1108 #1109

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Fixes #1108 #1109

merged 2 commits into from
Nov 10, 2022

Conversation

Thrameos
Copy link
Contributor

@Thrameos Thrameos commented Nov 9, 2022

Crash on NULL when JArray uses as the target of subscript.

@Thrameos Thrameos self-assigned this Nov 9, 2022
@Thrameos Thrameos added the bug Unable to deliver desired behavior (crash, fail, untested) label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1109 (63e3260) into master (d24008c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   88.67%   88.68%   +0.01%     
==========================================
  Files         111      111              
  Lines       10208    10211       +3     
  Branches     4014     4016       +2     
==========================================
+ Hits         9052     9056       +4     
  Misses        698      698              
+ Partials      458      457       -1     
Impacted Files Coverage Δ
native/python/pyjp_class.cpp 85.79% <100.00%> (+0.06%) ⬆️
native/common/include/jp_primitive_accessor.h 74.16% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Thrameos Thrameos merged commit 1da1101 into jpype-project:master Nov 10, 2022
@Thrameos Thrameos deleted the jarray_bug branch November 10, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unable to deliver desired behavior (crash, fail, untested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants