Windows locale #1174
Merged
Windows locale #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 87.45% 87.44% -0.01%
==========================================
Files 113 113
Lines 10236 10236
Branches 4057 4057
==========================================
- Hits 8952 8951 -1
Misses 692 692
- Partials 592 593 +1 ☔ View full report in Codecov by Sentry. |
|
@marscher This is meant to address #1111 but as I don't have a system that supports international paths for the JVM I can't really tell if it fixes anything more than moving the failure point. If the international testers do find it to fix the problem, I will complete this PR with the usual changelog entry, ask for a review, etc. |
|
Thanks at lot and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make JPype work when there are international characters in the path name. Currently does not appear to make a significant difference because the JVM itself does not support it on the tested system.