Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update userguide for swing #734

Merged
merged 4 commits into from May 15, 2020
Merged

Update userguide for swing #734

merged 4 commits into from May 15, 2020

Conversation

Thrameos
Copy link
Contributor

@Thrameos Thrameos commented May 9, 2020

Update the documentation regarding swing.

Fixes #730

@Thrameos Thrameos added the documentation Issue with our documentation (misleading, missing, bad) label May 9, 2020
@Thrameos Thrameos self-assigned this May 9, 2020
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #734   +/-   ##
=========================================
  Coverage     85.19%   85.19%           
  Complexity      287      287           
=========================================
  Files           129      129           
  Lines          9378     9378           
  Branches       3899     3899           
=========================================
  Hits           7990     7990           
  Misses          774      774           
  Partials        614      614           
Impacted Files Coverage Δ Complexity Δ
native/common/jp_platform.cpp 91.66% <0.00%> (ø) 0.00% <0.00%> (ø%)
native/java/org/jpype/manager/TypeManager.java 89.77% <0.00%> (ø) 106.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b64af...d438ab4. Read the comment docs.

Copy link
Contributor

@jeesang7 jeesang7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Very simple, nice ~

doc/userguide.rst Outdated Show resolved Hide resolved
Thrameos and others added 2 commits May 9, 2020 17:06
Co-authored-by: Jeesang Kim <30719956+jeesang7@users.noreply.github.com>
doc/userguide.rst Outdated Show resolved Hide resolved
@Thrameos Thrameos merged commit 44e4c70 into jpype-project:master May 15, 2020
@Thrameos Thrameos deleted the swing branch May 15, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue with our documentation (misleading, missing, bad)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call a class that extends javax.swing
3 participants