Funnel Chart Misaligned in Canvas Area in 1.0.9 #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… big in canvas and broken.
Issue Detail:- With Version 1.0.9, funnelchart plot is very big in size and going out of canvas area.This happens only if devicepixelratio is >1 in any browser and in firefox whose pixelratio is -1.
Analysis:- Observed that in jquery.jqplot.js InitCanvas method,Canvas is set based on device pixelratio.But in plugin file funnelrenderer.js CSS Canvas width and height is not considered for plotting funnel chart within canvas.This is causing issue.
This was handled only in pierenderer in version 1.0.9.
Solution:- Applied CSS Canvas width and height in draw function of funnelrenderer. Chart comes-up fine irrespective of device pixel ratio in all browsers.