Fix Autoconf checks on Darwin #2196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Autoconf checks merely verify that the symbol is available and linkable, but not that it's actually defined and usable. This breaks compilation on recent versions of macOS, where `lgamma_r()` is unavailable unless `_REENTRANT` is defined. Since this is rather difficult to detect, I strengthened the check so that it simple omits lgamma_r on macOS. While at it, I added support for `exp10()` on macOS, which is available, but named `__exp10` due to its nonstandard nature.
This was referenced Oct 21, 2020
danchr
force-pushed
the
autoconf-darwin
branch
from
0e841cf
to
8e1a4c0
Compare
This was referenced Feb 6, 2021
Closed
|
Hey, I also ran into this when attempting to build from the 1.6 release. Would you have a recommendation for how to resolve it for that? Also worth noting -- when I build it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Autoconf checks merely verify that the symbol is available and linkable, but not that it's actually defined and usable. This breaks compilation on recent versions of macOS, where
lgamma_r()is unavailable unless_REENTRANTis defined. Since this is rather difficult to detect, I strengthened the check so that it simply omits lgamma_r on macOS.While at it, I added support for
exp10()on macOS, which is available, but named__exp10due to its nonstandard nature.