Use a regex to parse ISO8601 dates #2296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strptimeis not consistently available and functional across operating systems; specifically, the code to parse timezones may or may not exist. This changesfromdateiso8601to support, via regexen, the two most common ISO 8601 date formats:dateTtimeZanddateTtime+00:00, where+00:00is an offset from GMT (the+can be a-for the western hemisphere).I believe this fixes bug #2195.
I am not sure if it would be desirable to also revert #1823 since that was (I believe) added specifically for
fromdateiso8601.