Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oniguruma workflow to test regex options #2723

Merged
merged 1 commit into from Jul 18, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jul 17, 2023

This PR introduces a new oniguruma Actions workflow to cover other options for --with-oniguruma. User can link with pre-installed library, or disable the option entirely. Automating these test cases prevents future regression of make check fails when built without oniguruma (e.x. #2292).

Copy link
Member

@emanuele6 emanuele6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicowilliams nicowilliams merged commit 0e3c391 into jqlang:master Jul 18, 2023
27 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants