Remove multiple calls to free when successively calling jq_reset.
#3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks. Possible to add a minimal reuse/reset regression test case to https://github.com/jqlang/jq/blob/master/src/jq_test.c that would be detected by valgrind? |
Sameesunkaria
force-pushed
the
fix-multiple-free
branch
from
63b2d0f
to
6ab6c29
Compare
|
Added a separate function for testing the Please let me know if you had something else in mind. :) |
wader
approved these changes
Jun 2, 2024
|
Please drop the change to gitignore file. Files generated not by the project should not be in per-project gitignore file. |
`jq_reset` calls `jv_free` on the `exit_code` and the `error_message` stored on the jq state. However, it doesn't replace the actual instance of those members. This means that subsequent calls to `jq_reset` will call `jv_free` again on those members, which in turn may call `free` on the same pointer multiple times. Freeing the same pointer multiple times is undefined behavior and can cause heap corruption, which is how I spotted this issue. In practice, this issue only occurs when using a program that may `halt_error`, because that is when the `exit_code` and `error_message` are set to values other than `jv_invalid`. Subsequent attempts to call `jq_start` (which calls `jq_reset` internally) after hitting a `halt_error` can cause you to run into this issue. The changes simply reset the `exit_code` and the `error_message` to `jv_invalid` (the initial value set in `jq_init`) after they are freed.
Sameesunkaria
force-pushed
the
fix-multiple-free
branch
from
6ab6c29
to
ae99179
Compare
|
Removed the commit with the changes to gitignore |
wader
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jq_resetcallsjv_freeon theexit_codeand theerror_messagestored on the jq state. However, it doesn't replace the actual instance of those members. This means that subsequent calls tojq_resetwill calljv_freeagain on those members, which in turn may callfreeon the same pointer multiple times. Freeing the same pointer multiple times is undefined behavior and can cause heap corruption, which is how I spotted this issue.In practice, this issue only occurs when using a program that may
halt_error, because that is when theexit_codeanderror_messageare set to values other thanjv_invalid. Subsequent attempts to calljq_start(which callsjq_resetinternally) after hitting ahalt_errorcan cause you to run into this issue.The changes simply reset the
exit_codeand theerror_messagetojv_invalid(the initial value set injq_init) after they are freed.