Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

::Fixnum is deprecated in Ruby 2.4 #16

Closed
ddarbyson opened this issue Dec 7, 2018 · 4 comments
Closed

::Fixnum is deprecated in Ruby 2.4 #16

ddarbyson opened this issue Dec 7, 2018 · 4 comments

Comments

@ddarbyson
Copy link

Ran into this today:

/home/username/.gem/ruby/2.4/gems/php-serialize-1.2.0/lib/php_serialize.rb:64: warning: constant ::Fixnum is deprecated

Nice gem btw!
@jqr
Copy link
Owner

jqr commented Dec 7, 2018

Yeah, Ruby 2.4 unified Fixnum and Bignum into just Integer.

I'm not using this gem any more but this should be an easy fix for someone who's eager to help.

@zdenkers
Copy link
Contributor

zdenkers commented Feb 19, 2020 •
edited

looks like someone fixed this issue back in 2017 but the gem never got updated. any chance you could update the gem with the latest? I also made the changes necessary to update the gem on ruby gems in a PR.

@jqr
Copy link
Owner

jqr commented Feb 19, 2020

Yep, working on that now.

@jqr
Copy link
Owner

jqr commented Feb 19, 2020

Merged #17 and Released as 1.3.0.

@jqr jqr closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jqr @ddarbyson @zdenkers