Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global variable declarations in formatters.pyi #230

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

mwchase
Copy link

@mwchase mwchase commented Nov 30, 2021

Convert aliases into type annotations, as was intended.

This needs some work to prove it out, since apparently mypy isn't cross-checking the py and pyi files, or it would have caught this?

Convert aliases into type annotations, as was intended.
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #230 (e44d033) into master (08417d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files           9        9           
  Lines        1014     1014           
  Branches      163      176   +13     
=======================================
  Hits          967      967           
  Misses         43       43           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08417d6...e44d033. Read the comment docs.

Copy link
Collaborator

@avylove avylove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you fixed a legitimate bug. Pylint failures are unrelated and already fixed. Thanks for your help with that.

@avylove avylove merged commit 1e53577 into jquast:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants