Add SupportsIndex support to sequence formatters #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy has been complaining about Sequence methods
ljust()
,rjust()
, andcenter()
which are part ofstr
, but overwritten. It looks like these use theSupportsIndex
type rather thanint
, which just means they have an__index__()
method. Most of the time this meansint
, but a custom type could implement the method and then you could use it instead of anint
.This PR fixes those type annotations and adds parity support to the
Sequence
formatting methods (rjust()
,ljust()
,center()
,truncate()
), so they can also take a custom class that implements the__index__()
method for width.