Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and minor updates #244

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Fix tests and minor updates #244

merged 3 commits into from
Jan 5, 2023

Conversation

avylove
Copy link
Collaborator

@avylove avylove commented Oct 28, 2022

Deprecated pytest-xdist option

Most of the tests are currently broken because pytest-xdist deprecated looponfail without an alternative. Since we have filterwarnings = error this causes the deprecation warning to be treated as a failure. Rather than pin pytest-xdist or figure out how to filter the deprecation, I thought it was easier to remove it.

pytest-dev/pytest-xdist#826


Test Updates

While I was in there, I moved the main test version to 3.10 and added 3.11 and 3.12-dev. 3.12-dev isn't currently available in the pipelines since 3.12 alpha 1 was released 2 days ago, but should be soon. It's tagged as optional.

The optional test syntax also seems to have changed, so I had to add continue-on-error. It's buggy in that it will show a success in the Actions view when a optional test fails, but the commit view still shows an X.


SupportsIndex

After some back and forth with the Pylint team, I realized using int(width) instead of width__index__() for the formatting methods was actually wrong. The latest Pylint handles this correctly and I added a commit to revert to the previous behavior. Also noticed one of the typing files was using int instead of SupportsIndex, so updated that too.


Other
Also made a handful of code tweaks, nothing significant.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 95.35% // Head: 95.15% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (204a443) compared to base (df28567).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   95.35%   95.15%   -0.20%     
==========================================
  Files           9        9              
  Lines        1011     1011              
  Branches      176      215      +39     
==========================================
- Hits          964      962       -2     
- Misses         43       45       +2     
  Partials        4        4              
Impacted Files Coverage Δ
blessed/sequences.py 100.00% <100.00%> (ø)
blessed/terminal.py 97.81% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avylove
Copy link
Collaborator Author

avylove commented Nov 10, 2022

3.12-dev is available now, currently alpha1, and it looks like we're passing.

@avylove
Copy link
Collaborator Author

avylove commented Jan 5, 2023

@jquast Can you approve this or give me access to approve my own PRs? The CI tests have been broken for the last couple months and it would be good to see them green again.

@avylove avylove merged commit 7a114c3 into master Jan 5, 2023
@avylove avylove deleted the oct_2022 branch January 5, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants