Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated pytest-xdist option
Most of the tests are currently broken because pytest-xdist deprecated
looponfail
without an alternative. Since we havefilterwarnings = error
this causes the deprecation warning to be treated as a failure. Rather than pin pytest-xdist or figure out how to filter the deprecation, I thought it was easier to remove it.pytest-dev/pytest-xdist#826
Test Updates
While I was in there, I moved the main test version to 3.10 and added 3.11 and 3.12-dev. 3.12-dev isn't currently available in the pipelines since 3.12 alpha 1 was released 2 days ago, but should be soon. It's tagged as optional.
The optional test syntax also seems to have changed, so I had to add
continue-on-error
. It's buggy in that it will show a success in the Actions view when a optional test fails, but the commit view still shows an X.SupportsIndex
After some back and forth with the Pylint team, I realized using
int(width)
instead ofwidth__index__()
for the formatting methods was actually wrong. The latest Pylint handles this correctly and I added a commit to revert to the previous behavior. Also noticed one of the typing files was using int instead of SupportsIndex, so updated that too.Other
Also made a handful of code tweaks, nothing significant.