Improve handling of combining characters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the canonical combining class was used to determine which characters are zero width combining characters. This had two problems: - it classified spacing marks (category Mc) as zero width - it classified enclosing marks (category Me) as normal characters Fix by using the general category to generate a table of combining characters that have zero width. Characters with a general category of Mn or Me are included in this table. Characters with a general category of Mc are not included, and so use the default width of 1.
|
This is Fantastic work @philipc ! I will Changelog and release soon! |
|
Finished review, very great work, thank you so much ! |
This was referenced Sep 14, 2015
|
Thanks for the review and merge. I should have mentioned that I left the COMBINING table in because the scripts in bin needed it still. I agree that we should remove it from the main library, but I wasn't sure of the best way to do that and keep the test scripts working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #10