feat(EurekaClient.js): Allow an independent EUREKA_ENV env variable. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows developers to select whatever Eureka env/config they need without having to rely on NODE_ENV. For example, we can set EUREKA_ENV to 'test', but keep NODE_ENV='production' for all the middleware and components in our library.
|
This seems good. I think the best way to handle environment overrides, would be to allow consumers to directly pass in the environment in the class constructor config instead of relying on magic env variables, but this pattern does fit without how it's currently being used. Can you also update the readme and increment the Thanks! |
jquatier
approved these changes
May 30, 2019
|
Thank you for the review, @jquatier. I don't have write access though, so I can't merge the PR myself. Could someone else merge it please and thank you? :) |
awolden
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to select whatever Eureka config file they need without having to rely on
NODE_ENV.For example, we can set
EUREKA_ENV=test, but keepNODE_ENV=productionfor all the middleware and components in our library.