V3 Release #60
Merged
V3 Release #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bugfix/dns-failure
This reverts commit e2a04ec.
|
Everything looks great. Good Job! 💯 |
|
Yep totally agree. Great Work! 🎱 |
| @@ -18,19 +19,32 @@ function noop() {} | |||
| for reporting instance health. | |||
| */ | |||
|
|
|||
| function fileExists(file) { | |||
| try { | |||
| return fs.statSync(file); | |||
There was a problem hiding this comment.
I would !! this to ensure consistent return types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release has a couple bugfixes, some improvements to usability, and some new features. Unit tests have also been added and improved.
Changes:
started,registered,deregistered,heartbeat, andregistryUpdated.fetchRegistries()now returns errors when they are encountered.UP,filterUpInstancescan be set tofalseto disable. See #48 for original issue.The main benefit of this release is the improved exception handling around DNS errors in AWS environments. Currently, if a DNS query were to fail (which is likely in a network outage) the client would throw an uncaught exception. The instance would most likely not recover when the network was available again (heartbeats stop). In V3, these errors are properly caught so that heartbeats continue to execute on interval. This scenario was simulated today and V3 resolves the issue completely.