-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Nested lists with same parent text resolve to the same sub-page. #1617
Comments
Bug! Here's a fiddle that illustrates this clearly. http://jsfiddle.net/stblack/z7nbj/ |
Within this fiddle I note that the link's |
Interesting. We'll definitely have to fix this. |
Keeping track of the number of lists per page through a hash in $.mobile and incorporating that count to the list id generation code might do the trick. In the test case above that would lead to the first "Parent Item" to have id: "#undefined&ui-page=Parent-Item-0-0" and the second one to have id: ""#undefined&ui-page=Parent-Item-1-0". Check out http://jsfiddle.net/ghislain/z7nbj/9/ |
Ghislain, is the |
The |
This reverts commit 3c7c73e.
Added unit test for issue #1617 for nested lists with thumbnails. THanks gseguin.
I just pulled in these tests. I think that @gseguin is right - don't these need unique parent item IDs in the hash for this to work? |
Nested lists with same parent text resolve to the same sub-page.
This appears to be broken as evidenced by the failing test in listview. More information here |
Nested lists with same parent text resolve to the same sub-page.
Handle case where page has an id (url), we want to use that as a key in the listCountPerPage dictionary
Nested lists with same parent text resolve to the same sub-page.
Handle case where page has an id (url), we want to use that as a key in the listCountPerPage dictionary
Nested lists with same parent text resolve to the same sub-page.
Handle case where page has an id (url), we want to use that as a key in the listCountPerPage dictionary
… resolve to the same sub-page.
… resolve to the same sub-page.
… resolve to the same sub-page.
Not sure if this has already been posted, but I couldn't find it.
I have a page with two list views. Each list view has an item with a nested list. The text of the parent item of the nested list is the same in each list view. The 'safe name' generated for the sub-page hash for both parent items resolves to the same name. So when viewing one of the sub-lists causes the wrong sub-list to be displayed. It looks like the sub-page hash is adding an index to help provide uniqueness for the sub-page hash, but the index is only for a given listview. When the next listview is encountered, the index resets and since the parent text is the same, the resulting sub-page hash conflicts with the sub-page list for the item in the previous list view.
Here is my example: (Not sure how to quote HTML source, but this looks the best...)
Note that when viewing the 'Parent Item' in the first list-view, the sub-list from the second 'Parent Item' is displayed. In looking at the link url, the hash values are the same: '#&ui-page=Parent-Item-0'.
Thanks
The text was updated successfully, but these errors were encountered: