destroy button widget fails with "this.button is undefined" error

[fdummert]

The _destroy method of a form button widget has a reference to "this.button" which is never populated:

_destroy: function() {
    this.element.insertBefore( this.button );
    this.button.remove();
}

A $(...).button("destroy") call consequently fails with an "this.button is undefined" error.

This bug was introduced by this commit and could be resolved by replacing "this.button" with "this.wrapper":

_destroy: function() {
    this.element.insertBefore( this.wrapper );
    this.wrapper.remove();
}

[jaspermdegroot]

@fdummert

Thanks for reporting the issue. Please, always include a test page when reporting bugs. See our contributing guidelines.

I created one for this issue: http://jsbin.com/sekujuqa/2/edit

@arschmitz - Should button be replaced by wrapper?

_destroy: function() {
    this.element.insertBefore( this.wrapper );
    this.wrapper.remove();
}

[gabrielschulhof]

Yeah, I think that's it. this.button is an instance-level variable that is only referenced in _destroy() and not initialized anywhere.