Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Build: Adopt UI download builder #8066

Open
gabrielschulhof opened this issue Apr 12, 2015 · 5 comments
Open

Build: Adopt UI download builder #8066

gabrielschulhof opened this issue Apr 12, 2015 · 5 comments
Assignees
Milestone

Comments

@gabrielschulhof
Copy link

  1. Gruntfile.js should be grabbing the version from <%= pkg.version %> instead
  2. onBuildWrite() needs to look for @VERSION, not __version__
  3. onBuildWrite() needs to remove the ( function( factory ) { if ( typeof define ... boilerplate, and construct an IIFE using the factory itself. This can be accomplished with esprima.
@gabrielschulhof gabrielschulhof self-assigned this Apr 12, 2015
@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Apr 12, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 12, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 12, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 12, 2015
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 12, 2015
@arschmitz
Copy link
Contributor

#2 and #3 are not needed. The @Version replacement is part of the release build along with striping the wrapper when we switch to ui download builder. The files we build here are just for development / testing. We wont be using these files for the cdn. The cdn will use download builder to generate its files. See the first 2 functions in https://github.com/jquery/jquery-ui/blob/master/build/release.js

@gabrielschulhof
Copy link
Author

OK. It looks like the download builder will also be able to provide an implementation of --modules by replacing ":all:" with the list of modules requested at the command line, unless I've misread https://github.com/jquery/jquery-ui/blob/master/build/release.js#L41.

So, we can even get rid of onBuildWrite().

Come to think of it, shall we make this into an issue about adopting the UI download builder? I'd be happy to take that on.

@arschmitz
Copy link
Contributor

Yes that sounds good.

@gabrielschulhof gabrielschulhof changed the title Build: More improvements are needed Build: Adopt UI download builder Apr 17, 2015
@apsdehal
Copy link
Contributor

apsdehal commented May 8, 2016

@gabrielschulhof Any plans to pick this up again, it would require a lot of changes in the branch.

@Bachstelze
Copy link

Could we move this to the next milestone?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants