This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fix for issue #4133 - check all items on each change when custom filter callback applies #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms for filter if present.
|
Also permits forced re-filtering of the lists with $("#myList input.ui-input-text").trigger('change') after a listview refresh. |
| @@ -43,11 +43,16 @@ $( document ).delegate( ":jqmData(role='listview')", "listviewcreate", function( | |||
| itemtext = "", | |||
| item; | |||
|
|
|||
| // Check if a custom filter callback applies | |||
| var isCustomFilterCallback = listview.options.filterCallback != | |||
| $.mobile.listview.prototype.options.filterCallback; | |||
There was a problem hiding this comment.
I think check only works when the callback is defined using the widget factory method
$( "#mylist" ).listview( 'option', 'filterCallback', yourFilterFunction );If the user sets the value via the prototype options value eg,
$( document ).bind( "mobileinit", function(){
$.mobile.listview.prototype.options.filterCallback = function(){
console.log( "foo" );
}
});This check will always return true though it's clearly a custom callback.
|
Other than the inline comment I agree with the suggested behavior. This will probably have to wait until 1.2 though. |
|
I'm going to close this one because we haven't seen a response on the filter comparison. |
npmcomponent
pushed a commit
to npmcomponent/cbou-jquery-mobile
that referenced
this pull request
Jan 8, 2014
…ll list of items. Fixes #4133 Largely inspired by jquery-archive/jquery-mobile#4135
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4133 - check all items on each change when custom filter callback applies. This allows custom filters to truly add their own interpretation of the input filter value.