Checkboxradio: Fixed a bug that the input type="radio" button without the name attribute is not changed to the checked status when it is clicked. #6659
Conversation
For your information, the input type="checkbox" button without the name attribute is changed to the checked status properly for both cases, due to the code block of #L187. : https://github.com/jquery/jquery-mobile/blob/master/js/widgets/forms/checkboxradio.js#L187 |
Good catch! |
This is not a regression from 1.3.2: http://jsbin.com/ofuhaw/711/ |
@gabrielschulhof : Thanks. :) Yes, 1.3.2 also has this issue/bug. |
@hyunsook you are correct there is a bug that needs to be fixed the reason @gabrielschulhof mentions it is not a regression is because at the point we are in the release process unless something is a major regression any fixes will need to wait for 1.4.1 unless its substantial enough to warrant a second RC |
… the name attribute is not changed to the checked status when it is clicked.
@hyunsook Can you please update your git config to use your full name matching what you signed the cla with. After that i think this is good to go. |
I've fixed those things and I've moved the commit to #7082. |
I guess this PR should auto-close when I apply #7082. |
Changes Unknown when pulling a6e4bb5 on hyunsook:pr-1.4-checkoutradio-radio-getInputSet into * on jquery:master*. |
In the end, we've decided to go with a simpler solution: Simply add |
@arschmitz : Oh no! I'm truly sorry I wasn't aware of your message. |
Hi All~!
If a page does not include jQM but include jQuery, the input type="radio" button is changed the checked status properly when it is clicked although the radio button doesn't have the name attribute.
But, if jQM is added on that page, the radio button is not changed the checked status.
To fix this bug, I submit this PR.
If there are any problems or mistakes on that PR, please let me know.
Thanks in advance. :)