This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Remove inline height from .ui-panel-dismiss on _closePanel #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not removing the height from .ui-panel-dismiss breaks the layout if the page height is changed dynamically once the panel has open and closed once.
|
@devben Thanks for this PR can you please take a moment and sign our CLA http://contribute.jquery.org/CLA/ once that is done i will be happy to take a look at this. |
|
This PR needs testing and an issue that it fixes. |
|
You can see this issue here http://jsfiddle.net/3JzuP/ |
|
@devben Right, sorry, and thanks for the link :) I meant that we need to open a new issue and then modify the commit message to say that it fixes the issue. I'll do these things - don't worry about it. |
| @@ -397,7 +397,8 @@ $.widget( "mobile.panel", { | |||
| } | |||
|
|
|||
| if ( self._modal ) { | |||
| self._modal.removeClass( self._modalOpenClasses ); | |||
| self._modal.removeClass( self._modalOpenClasses ) | |||
| .height(""); | |||
There was a problem hiding this comment.
need spaces inside parentheses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not removing the height from .ui-panel-dismiss breaks the layout if the
page height is changed dynamically once the panel has open and closed
once.