Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

7360 table review #7372

Closed
wants to merge 74 commits into from
Closed

7360 table review #7372

wants to merge 74 commits into from

Conversation

gabrielschulhof
Copy link

Fixes gh-7360

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone May 6, 2014
@gabrielschulhof
Copy link
Author

API docs PR: jquery/api.jquerymobile.com#307

@coveralls
Copy link

Coverage Status

Coverage increased (+0.52%) when pulling ec0add5 on 7360-table-review into 39fe09e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.58%) when pulling 410bb4a on 7360-table-review into 039c0b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.58%) when pulling 25af352 on 7360-table-review into 039c0b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.58%) when pulling 3349e02 on 7360-table-review into 039c0b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.62%) when pulling fea9997 on 7360-table-review into 039c0b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.43%) when pulling f5136a2 on 7360-table-review into 2f7d1c6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.87%) when pulling 7351fde on 7360-table-review into 14c712f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.87%) when pulling 27977b8 on 7360-table-review into 14c712f on master.

Gabriel Schulhof added 14 commits August 29, 2014 09:03
Table: Flatten out _refresh() and restrict colstart DOM manip to reflow
991f891
Table: Add _destroy()
ee17c0a
Table: Test _destroy()
d23e8f3
Table: Remove $.extend() and simplify _setHeaders()
88dcb49
Table: Record UI elements both when pre-rendered and not
1c6ea65
Table: _destroy() re-format
3145bff
Table: Implement _setOptions() for "disabled"
29eecce
Table: Simplify reflow instantiation
4a9cd91
Table: "create" parameter for _refresh() is only used in columntoggle
1745747 
Thus, replace it with an instance variable turned on at the beginning of
_create() and turned off at the end of _create(). This removes the need for
_refresh(). refresh() can now handle the actual refresh, and rebuild() becomes
and alias for refresh(). We should deprecate rebuild() in favour of refresh().
Table: Replace references to "rebuild" with "refresh" in the tests
1b1b84b
Table: Testing disable and grouped headers
f08f9c7
Table: Implement _setOptions() for style options
cee5eda
Table: Add columntoggle style option tests
42a0ed8
Table: Simplify the way headers are retrieved
6979461 
This also speeds things up: http://jsperf.com/table-header-selector
Gabriel Schulhof added 19 commits August 29, 2014 09:04
Table: Add test for prerendered reflow _destroy()
ddfb7de
Table: Test grouped header case with only one subheader in the group
7e0866e
Table: Add columntoggle test for setColumnVisibility()
dd43419
Table: Test setColumnVisibility() when there's a popup
84c90f7
Table: Add columntoggle test for generated widget ID
4eb5e64
Table: Test turning on columnButton when it's initially false
5863d18
Table: Test correct enhancement when option columnUi is initially false
4ac1ab7
Table: Account for enhanced case when columnButton gets turned on
8b123f4
Table: add class ui-state-disabled if initially disabled
687d78c
Table: Demo setColumnVisibility() and custom UI with columnUi: false
318e0c8
Table: Moving existing tests to integration/
91fe879
Table: True unit tests for the basic table
c99f6bb
Table: Add prefix to _create() test
a742bf5
Table: Add reflow table unit tests
b6cff3b
Table: Correct grouped tests
11905be
Table: Correctly assert contents of grouped header "cells" key
9d9a99e
Table: Update reflow comment about processing headers in reverse
529bed5
Table: Add columntoggle unit tests
90aa28a
Table: Move _recordLockedColumns() and _restoreLockedColumns() to popup
0a8635c
@arschmitz
Copy link
Contributor

@gabrielschulhof Lets get this rebased on the classes pr once thats updated to new api

@arschmitz
Copy link
Contributor

replaced by #8349

@arschmitz arschmitz closed this Mar 26, 2016
@arschmitz arschmitz deleted the 7360-table-review branch August 22, 2016 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gabrielschulhof gabrielschulhof

Labels
Action: PR needs modification Component: Table
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Table: Review widget
4 participants
@gabrielschulhof @coveralls @arschmitz @jaspermdegroot