This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Panel: no longer jump up on resize #7674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should not scroll to top in just resize window Fixes jquery-archive#7572
|
Thanks for your contribution! |
|
@gabrielschulhof thank you. how to make review request for this PR ? |
|
@shao1555 Sorry! I'll set up the flags. |
|
Will this also disable scroll to top when panel is shown? |
|
@shao1555 can you explain why you are changing the check to explicitly check for true rather then just a truthy value and how this reflects a resize vs a non resize? |
|
Im going to close this there has been no response to several questions in a month we can re open if the OP answers. |
|
@arschmitz, @borg4242 explains it in #7923: you must check strictly for |
gabrielschulhof
pushed a commit
to gabrielschulhof/jquery-mobile
that referenced
this pull request
Jan 19, 2015
should not scroll to top in just resize window Fixes jquery-archivegh-7572 Closes jquery-archivegh-7674
kakul
pushed a commit
to kakul/jquery-mobile
that referenced
this pull request
Apr 14, 2015
should not scroll to top in just resize window Fixes jquery-archivegh-7572 Closes jquery-archivegh-7674
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should not scroll to top in just resize window
Fixes #7572