This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Selectmenu: Filterable demo now filters/refreshes selectmenu widget #7681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
7677-selectmenu-custom-filter-data-filterable
branch
from
2e61ffd
to
800081b
Compare
| // We only handle the appearance of a dialog generated by a filterable selectmenu | ||
| if ( !$( ".filterable-select" ).is( function() { | ||
| return ( ( $( this ).attr( "id" ) + "-dialog" ) === id ); | ||
| })) { |
There was a problem hiding this comment.
This is a pretty ugly if why dont we just do $( ".filterable-select" ).attr( "id" ) + "-dialog" !== id?
There was a problem hiding this comment.
... because $( ".filterable-select" ) contains multiple elements and we need to check the id of each, not just the first.
Do you think the following alternative is more legible?
var dialogBelongsToSelectmenu = false;
$( ".filterable-select" ).each( function() {
if ( $( this ).attr( "id" ) + "-dialog" === id ) {
dialogBelongsToSelectmenu = true;
return false;
}
});
if ( dialogBelongsToSelectmenu ) {There was a problem hiding this comment.
Another alternative is to keep the check but improve the comment. Something like
// Check all the select menus to see if the id of the dialog matches the id of one of them, because
// we only handle the appearance of a dialog generated by a filterable selectmenu
gabrielschulhof
force-pushed
the
7677-selectmenu-custom-filter-data-filterable
branch
from
0720195
to
8af51cc
Compare
| id = page && page.attr( "id" ); | ||
|
|
||
| $( ".filterable-select" ).each( function() { | ||
| if ( ( $( this ).attr( "id" ) + "-dialog" ) === id ) { |
|
👍 |
gabrielschulhof
deleted the
7677-selectmenu-custom-filter-data-filterable
branch
agcolom
pushed a commit
to agcolom/jquery-mobile
that referenced
this pull request
Nov 26, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7677
... and actually fixes a bug in the existing selectmenu-custom-filter demo whereby the filter input does not return to the popup if the menu is ever shown as a dialog.