-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed jquery requirement from core.js #30
Removed jquery requirement from core.js #30
Conversation
I like the change, but the Also, don't forget to put a note in the README that you need to |
@@ -1,5 +1,10 @@ | |||
# master | |||
|
|||
# 3.0.1 [BREAKING CHANGE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit this line. I'll add a 4.0.0
section when I release.
Thanks for elucidating, Stuart! For posterity, original discussion is at #17. |
Hey! I think I need to reconfigure the GH settings, I don't have any mail updates :/ Good point about Rakefile, somehow I missed that part. Should I update it? |
Yes please, and remove the existing change to |
Ok - done. I also checked testapp this time, and everything still works ;) |
Sweet. Could you squash the commits please, with |
Stripped Rakefile from jquery dependencies and regenerated assets
Here you go, should be fine now |
Removed jquery requirement from core.js
Thanks Leszek! I just pushed out version 4.0.0. |
I don't think that including jquery in jquery.ui.core is a good idea, because some can get it i.e. from CDN, or require it anyway - it's not mentioned that it's required by UI.