Core: Do not search the whole DOM for radio/checkbox elements

Fixes #1056 Closes #1064
jquery-validation · Feb 17, 2015 · 64d6d7f · 64d6d7f
1 parent 60dd410
commit 64d6d7f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/core.js b/src/core.js
@@ -582,7 +582,7 @@ $.extend( $.validator, {
 				type = element.type;
 
 			if ( type === "radio" || type === "checkbox" ) {
-				return $( "input[name='" + element.name + "']:checked" ).val();
+				return this.findByName( element.name ).filter(":checked").val();
 			} else if ( type === "number" && typeof element.validity !== "undefined" ) {
 				return element.validity.badInput ? false : $element.val();
 			}

diff --git a/test/test.js b/test/test.js
@@ -748,6 +748,13 @@ test( "findLastActive()", function() {
 	equal( v.lastActive, lastActive );
 });
 
+test("elementValue() finds radios/checkboxes only within the current form", function() {
+	expect(1);
+	var v = $("#userForm").validate(), foreignRadio = $("#radio2")[0];
+
+	ok( !v.elementValue(foreignRadio) );
+});
+
 test( "validating multiple checkboxes with 'required'", function() {
 	expect( 3 );
 	var checkboxes = $( "#form input[name=check3]" ).prop( "checked", false ),