Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thousands separators allowed for numbers, but not min/max #379

Closed
adammessinger opened this issue Apr 17, 2012 · 4 comments
Closed

Thousands separators allowed for numbers, but not min/max #379

adammessinger opened this issue Apr 17, 2012 · 4 comments

Comments

@adammessinger
Copy link

While trying to validate a number field with min and max attributes, I noticed that there was no invalid number complaint for something like "9,000" but that adding commas would cause the value to incorrectly fail min/max validation.

@jzaefferer
Copy link
Collaborator

Duplicate of #188 - should integrate Globalize to solve this properly.

@Spongman
Copy link

this is a joke. both issues #188 and #379 which have been unfixed for years are closed referring to each other as reasons for closing. yet this fix STILL has not made it into release.

@joeRinehart
Copy link

+1 to the above. This is a joke. Implement the common case (whichever international format is preferred for the library's authors) and give developers a way to extend/change it.

@joeRinehart
Copy link

In case anyone hits this and needs a quick, U.S.-but-customizable fix, I already had numeral.js involved and using it to preformat values was a pinch:

https://gist.github.com/joeRinehart/0e8af523fdfc567cc670ddca2eaff137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants