New method: notEqualTo #1020
Closed
New method: notEqualTo #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New method ‘notEqualTo’ that delegates to the notEqual method and returns the inverted value.
| @@ -0,0 +1,3 @@ | |||
| jQuery.validator.addMethod( "notEqualTo", function( value, element, param ) { | |||
| return !$.validator.methods.equalTo.call( this, value, element, param ); | |||
There was a problem hiding this comment.
Shouldn't this also respect the optional state like other methods do?
There was a problem hiding this comment.
I had assumed I'd get that for free since I'm delegating to the existing method equalTo? I'll verify that and add if not.
|
There are no notifications for new commits, so I never noticed that you added one until now. Trying to merge this now causes merge conflicts - could you rebase this PR and squash it into one commit? Thanks. |
|
yes. |
Conflicts: test/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method ‘notEqualTo’ that delegates to the notEqual method and
returns the inverted value.