core: Fix incorrect regexp #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Thanks for immediate fix! |
|
You're most welcome. :) Got to earn my keep somehow. 😀 |
|
@jzaefferer is there anything here that is being blocked by something? A few people have come across this so far and it would be good to get fixed. |
|
Thanks for the fix and reminder. Just landed this, only edited the commit message to include ticket references. |
|
Thanks @jzaefferer :) |
|
NOT fixed in 1.13.1 (from nugget) If using (for example) an id like "avd.Enabled", it fails to match and adds forever |
|
looks fixed for me in 1.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1200