Proposed fix for #1378 - Added parseFloat before value and param are com... #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compared. Fix #1378 - value and param variables should be typecast before comparison. This is required if rules are specified through data-attributes
|
Why did you close this? |
|
Hi Jörn, I closed the pull request because i realized it didnt pass all the tests. My apologies for that... I realized also that my solution will not work if date and string comparison is required. ZR |
|
Okay, thanks for letting me know. If you can find a solution that solves the problem you reported, let me know, another PR is definitely welcome. |
|
Hi Jörn, Thanks for the encouragement.. I'm new to GitHub and i'm sorry for creating lots of unwanted commits... Here's my latest PR. This time round, it fixes the issue reported and passes the travis test. ZR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1378 - value and param variables should be typecast before
comparison. This is required if rules are specified through
data-attributes