Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jquery dependencies to dev dependencies #1858

Closed
wants to merge 1 commit into from

Conversation

inomdzhon
Copy link

@inomdzhon inomdzhon commented Sep 8, 2016

I installed jquery-validation from npm. After compiled with webpack I have two version jquery on my bundle, first - mine, second - it is the plugin jquery dependencies. And so I moved this dependencies to dev dependencies.

Weird, why this package have own node_modules on folder after installed with npm

@staabm
Copy link
Member

staabm commented Sep 9, 2016

Jquery is not a dev but a runtime dependency for jquery-validate. Therefore I think this change is not correct.

How did you declare your other jquery dependency?

@inomdzhon
Copy link
Author

inomdzhon commented Sep 9, 2016

@staabm I installed them from npm and set aliases $, jquery, jQuery for requiring like this require('jquery') and etc.

As jquery-validation have own node_modules folder, it defining jquery from there.

I now understand that my changed useless. Where from npm getting jquery-validation? On this repo have another structure and package.json than npm installed.

@staabm
Copy link
Member

staabm commented Sep 26, 2016

the version which is available via npm is managed in this repo.

@staabm staabm force-pushed the master branch 2 times, most recently from d621aab to 3861ce2 Compare September 26, 2016 14:28
@Guymestef
Copy link
Contributor

@svarnoi420 What's the jquery version you're using in your package.json?

I have this problem too, and I think it's because I use the latest jquery version (v3) but jquery.validation has a dependency on jquery ^1.7 || ^2.0. So webpack build jquery.validation with jquery v2 and all other libs with jquery v3.

@inomdzhon
Copy link
Author

@Guymestef Yeah, I use jquery v3 too. Hm, I didn't think about this can be reason. I'll try install jquery v2 for analyze.

@staabm
Copy link
Member

staabm commented Dec 1, 2016

I just landed a PR which added support for jquery3.x, will close therefore. feel free to provide further information in case this was not resolved by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants