Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for button elements with descendants #1901

Merged
merged 13 commits into from Jan 28, 2017

Commits on Dec 3, 2016

  1. Added support for button elements with descendants

    Non-Firefox browsers dispatch "click" on descendants of <button>, which breaks
    the submitHandler logic that adds a hidden field with the name and value of the
    submit button (since it is not included in the submission if it did not
    initiate the submission, which might be the case when using form.submit in
    submitHandler and returning false). submitButton is instead a descendant of
    <button> and the hidden field does not compensate for the lack of an actual
    submit button.
    
    This would fix crbug.com/668524 and make submitButton an actual button.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    4db936e View commit details
    Browse the repository at this point in the history
  2. Added HTML for button with descendants test

    For testing that clicking on descendants of a button element still keeps the button element as the submit button.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    002a675 View commit details
    Browse the repository at this point in the history
  3. Added a test for button with descendants support

    For testing that clicking on descendants of a button element still
    keeps the button element as the submit button.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    ba3c07a View commit details
    Browse the repository at this point in the history
  4. Removed an extraneous submission from the test

    Accidental copy-paste.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    c7086fc View commit details
    Browse the repository at this point in the history
  5. Fixed some style warning

    Forgot to wrap the parenthesized value with spaces.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    4451f0a View commit details
    Browse the repository at this point in the history
  6. Fixed a style warning

    Forgot to wrap a parenthesized value with spaces.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    34926c2 View commit details
    Browse the repository at this point in the history
  7. Fixed a style warning

    Forgot to add a blank line above a comment.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    772a8f3 View commit details
    Browse the repository at this point in the history
  8. Fixed the button with descendants test

    Replaced a complex event initiation with a basic click().
    phistuck committed Dec 3, 2016
    Copy the full SHA
    649b1da View commit details
    Browse the repository at this point in the history
  9. Fixed a style warning

    Removed extraneous trailing spaces.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    fecd32f View commit details
    Browse the repository at this point in the history
  10. Fixed some style warnings

    Removed two unused variables.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    e0e0728 View commit details
    Browse the repository at this point in the history
  11. Fixed a submitButton regression

    Instead of returning a DOM element, a jQuery element was returned.
    Changed to return the original element in the target is already a button case.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    d85cc3c View commit details
    Browse the repository at this point in the history
  12. Simplified the button with descendants support

    Instead of looking for the parent or ancestor of the target,
    just used the currentTarget property.
    phistuck committed Dec 3, 2016
    Copy the full SHA
    c257fc0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2017

  1. Added another test

    Devised by @Arkni.
    phistuck committed Jan 27, 2017
    Copy the full SHA
    5b0d85e View commit details
    Browse the repository at this point in the history