Core: Don't call submitHandler when in debug mode #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
staabm
reviewed
Jul 29, 2018
src/core.js
Outdated
| @@ -64,7 +65,8 @@ $.extend( $.fn, { | |||
| .appendTo( validator.currentForm ); | |||
| } | |||
|
|
|||
| if ( validator.settings.submitHandler ) { | |||
| // Only call the submit handler in case the validator is not on debug mode | |||
There was a problem hiding this comment.
The comment does not provide value.
There was a problem hiding this comment.
Would it make sense to write a console.log in debug mode instead?
There was a problem hiding this comment.
Yeah, you're right! It doesn't have any additional value. I don't know why I wrote that comment in the first place (it was around 2AM when I created this PR). Will remove it in a moment.
As for the console.log, it will not make sense to print that the submitHandler will not be called when it supposed to not be called in the first place. So, we will just let it that way.
Arkni
force-pushed
the
submithandler-issue-2042
branch
from
d38c997
to
b115011
Compare
staabm
approved these changes
Jul 29, 2018
|
Thanks for the review @staabm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2042