Reentrancy issue with remote method #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing a custom variant of the remote method i found that I had to move up this guard otherwise `previous.originalMessage` would get stomped on a reentrant invocation. To be clear, I haven't confirmed this using the `remote` method directly but I am using all the same boilerplate and just changing my method name (and some details about how the response is handled). Also I believe `previous.message` should not be getting assigned a resolved value in the case it's a function, otherwise it will always remain that static value instead of dynamically updating on the next error. I figured it was worth mentioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a custom variant of the remote method i found that I had to move up this guard otherwise
previous.originalMessagewould get stomped on a reentrant invocation. To be clear, I haven't confirmed this using theremotemethod directly but I am using all the same boilerplate and just changing my method name (and some details about how the response is handled).Also I believe
previous.messageshould not be getting assigned a resolved value in the case it's a function, otherwise it will always remain that static value instead of dynamically updating on the next error.I figured it was worth mentioning.