-
Notifications
You must be signed in to change notification settings - Fork 162
README: Restructure everything, overhaul details, add logo #247
Conversation
I added a line break to stop the mini float and added a simple working html page into the example at the top. https://github.com/roblarsen/PEP/blob/readme-updates/README.md |
|
||
By default, no Pointer Events are sent from an element. This maximizes possibility that a browser can deliver smooth scrolling and jank-free gestures. If you want to receive events, you must set the `touch-action` property of that element. | ||
1. Place the PEP script in the document head | ||
- `<script src="https://code.jquery.com/pep/0.3.0/pep.js"></script>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.4.0 now that that's out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it should. Updated.
43d819f
to
36035df
Compare
Thanks @roblarsen! I've integrated the demo in this branch (with your commit). |
👍 |
<title>PEP (Pointer Events Polyfill)</title> | ||
<meta name="viewport" content="width=device-width"> | ||
<!-- include PEP --> | ||
<script src="https://code.jquery.com/pep/0.4.0/pep.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need an accompanying change to the release script to update the version in the README, otherwise this will get out of date.
2bea631
to
77e6921
Compare
Updated to fix the formatting of the new snippet (2nd commit). As for the release script update, that can wait a little longer, since the existing reference was already outdated. |
Got some more reviews during today's PEP meeting, nothing came up, so I merged it. |
This mixes a bunch of changes, but should still be easy enough to review.
Looking for better ideas for embedding the logo.