Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

README: Restructure everything, overhaul details, add logo #247

Merged
merged 2 commits into from
Dec 17, 2015

Conversation

jzaefferer
Copy link
Contributor

This mixes a bunch of changes, but should still be easy enough to review.

Looking for better ideas for embedding the logo.

@jzaefferer jzaefferer mentioned this pull request Dec 10, 2015
@roblarsen
Copy link
Contributor

I added a line break to stop the mini float and added a simple working html page into the example at the top.

https://github.com/roblarsen/PEP/blob/readme-updates/README.md


By default, no Pointer Events are sent from an element. This maximizes possibility that a browser can deliver smooth scrolling and jank-free gestures. If you want to receive events, you must set the `touch-action` property of that element.
1. Place the PEP script in the document head
- `<script src="https://code.jquery.com/pep/0.3.0/pep.js"></script>`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0.4.0 now that that's out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should. Updated.

@jzaefferer
Copy link
Contributor Author

Thanks @roblarsen! I've integrated the demo in this branch (with your commit).

@roblarsen
Copy link
Contributor

👍

<title>PEP (Pointer Events Polyfill)</title>
<meta name="viewport" content="width=device-width">
<!-- include PEP -->
<script src="https://code.jquery.com/pep/0.4.0/pep.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need an accompanying change to the release script to update the version in the README, otherwise this will get out of date.

@jzaefferer
Copy link
Contributor Author

Updated to fix the formatting of the new snippet (2nd commit). As for the release script update, that can wait a little longer, since the existing reference was already outdated.

@jzaefferer jzaefferer merged commit 77e6921 into master Dec 17, 2015
@jzaefferer
Copy link
Contributor Author

Got some more reviews during today's PEP meeting, nothing came up, so I merged it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants