Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of a typing error in the second option "hide" #1

Merged
merged 1 commit into from
Jun 6, 2012
Merged

Fix of a typing error in the second option "hide" #1

merged 1 commit into from
Jun 6, 2012

Conversation

igochkov
Copy link
Contributor

@igochkov igochkov commented Jun 6, 2012

No description provided.

@jzaefferer jzaefferer merged commit cd39196 into jquery:master Jun 6, 2012
@jzaefferer
Copy link
Member

Thanks, merged! Here's hoping for more significant contributions :-)

@igochkov
Copy link
Contributor Author

igochkov commented Jun 6, 2012

I am writing a generator for jQueryUI API Library for Script#. api.jqueryui.com is an excellent source for this automation. That is why I need to fix the typos first to have correct generation :) I might have some suggestions for the xml schema to simplify parsing. For example I noticed that an option has a type as an xml attribute but also can have types specified as xml nodes. What is the difference between those two? Do you have xml schema already defined in separate file?

@jzaefferer
Copy link
Member

That's a good point about the type. We've started with the attribute, then added the elements to rely less on multi-attributes like type="jQuery, String", but for single types, having an attribute keeps things a lot simpler. For our XSLT, accepting both is actually fine.

We don't have a XML schema, and I'd rather not bother creating one - maintaining the xml content and xslt is work enough...

For specific issues, feel free to create issues on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants