New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: List jQuery Core module files if present #97
Conversation
Note that this does not add factory files - they are meant for Node.js so we don't plan to upload them to the CDN, just make them available in the npm package (and the bower one but that's just because contents are the same). |
For now, the module files only exist for the Git builds as they will only be available starting with jQuery 4.0.0. Those already exist so you can check them. |
For "slim", we label it "slim" and "slim minified", with a space instead of parenthesis. I tend to avoid parenthesis in navigational links when possible, to make it feel less complex to the reader. Today: If we follow the wording for "slim":
With more labels and parenthesis:
Vertical separation:
Hm.. in that case, do we need the above logic? Or would we only need the |
@Krinkle We don't plan to upload factory files: or Node module wrapper files:
We do plan to upload module files:
so yes, this additional logic is needed. The list gets quite long now so I like the vertical separation idea. I'll need to refactor the code a bit for that. |
296b75c
to
405e57b
Compare
405e57b
to
d67f7d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change is still not deployed at https://releases.jquery.com/jquery/. I tested it locally and it worked. Any ideas? |
Actually, no commit since 53da218 is getting deployed. I posted on |
No description provided.