Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: List jQuery Core module files if present #97

Merged
merged 2 commits into from Feb 5, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Sep 21, 2023

No description provided.

@mgol
Copy link
Member Author

mgol commented Sep 21, 2023

Note that this does not add factory files - they are meant for Node.js so we don't plan to upload them to the CDN, just make them available in the npm package (and the bower one but that's just because contents are the same).

@mgol
Copy link
Member Author

mgol commented Sep 21, 2023

For now, the module files only exist for the Git builds as they will only be available starting with jQuery 4.0.0. Those already exist so you can check them.

@Krinkle
Copy link
Member

Krinkle commented Sep 22, 2023

For "slim", we label it "slim" and "slim minified", with a space instead of parenthesis. I tend to avoid parenthesis in navigational links when possible, to make it feel less complex to the reader.

Today:

uncompressed, minified, slim, slim minified.

If we follow the wording for "slim":

uncompressed, minified, slim, slim minified, module, module minified, slim module, slim module minifed.

With more labels and parenthesis:

uncompressed, minified, slim (uncompressed), slim (minified), module (uncompressed), module (minified), slim module (uncompressed), slim module (minifed).

Vertical separation:

script: uncompressed, minified, slim, slim minified
module: uncompressed, minified, slim, slim minified.

Note that this does not add factory files - they are meant for Node.js so we don't plan to upload them to the CDN, just make them available in the npm package […]

Hm.. in that case, do we need the above logic? Or would we only need the -git links in that case, which are a separate part of the patch afaik. The above is only applied to CDN and stable releases, right?

@mgol
Copy link
Member Author

mgol commented Sep 22, 2023

@Krinkle We don't plan to upload factory files:

or Node module wrapper files:

We do plan to upload module files:

so yes, this additional logic is needed.

The list gets quite long now so I like the vertical separation idea. I'll need to refactor the code a bit for that.

@mgol
Copy link
Member Author

mgol commented Jan 26, 2024

PR updated. The latest state of the home page limited to the jQuery Core section:
Screenshot 2024-01-27 at 00 45 43

and the jQuery Core page itself:
Screenshot 2024-01-27 at 00 45 27

I changed hyphens to colons universally as hyphens look bad in the multiline setup and IMO it's better to settle on one for consistency.

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed the Needs review label Feb 5, 2024
@mgol mgol merged commit 7ceb4ef into jquery:main Feb 5, 2024
1 check passed
@mgol mgol deleted the list-core-module-files branch February 5, 2024 17:16
@mgol
Copy link
Member Author

mgol commented Feb 8, 2024

This change is still not deployed at https://releases.jquery.com/jquery/. I tested it locally and it worked. Any ideas?

@mgol
Copy link
Member Author

mgol commented Feb 8, 2024

Actually, no commit since 53da218 is getting deployed. I posted on #jquery-infra on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants