Harmony: Shorthand functions in objects do not add the shorthand flag

[qfox]

Code:

var obj = {
  myfunc() { return null; }
}

myfunc node doesn't have truthy shorthand property.

{ type: 'Property',
  key:
   { type: 'Identifier',
     name: 'myfunc',
     range: [ 16, 22 ],
     loc: { start: [Object], end: [Object] },
     parentNode: [Circular],
     parentCollection: [ undefined ] },
  value:
   { type: 'FunctionExpression',
     id: null,
     params: [],
     defaults: [],
     body: { ... }, ... },
  kind: 'init',
  method: true,
  shorthand: false, // !!! here it is
  computed: false,
  parentNode: ...

Ref jscs-dev/node-jscs#1013

[michaelficarra]

It has the method flag. shorthand must refer to {a} style properties, no?

edit: You are probably confused because these are just called methods, not "shorthand" methods. {a} properties are called shorthand properties.

[qfox]

@michaelficarra yes, probably. Does it standardized? What's the difference between foo : function bar() { } and fooBar() { }?

[michaelficarra]

The former can refer to itself by name. The latter can make super method calls and has a bound this.

[qfox]

@michaelficarra okay. What's about:

var myfunc = function () { return 'asd'; };
var myobj = { myfunc };
console.log(myobj.myfunc()); // asd

Here I have myfunc and it's shorthand but not a method, right? That's very confusing.

[michaelficarra]

Yes. Not confusing to me. The flag is on the property, not the value.

[qfox]

So you totally sure that it shouldn't have shorthand truthy?

Oh. As I see, method flag is only set for { myfunc() { } } notation. So I should use it for methods as well as shorthand for properties. Right?
Just to be sure: does method flag is used for something else?

[michaelficarra]

Nope, that's what you're looking for.

[qfox]

@michaelficarra Thanks!