Generated customFields for added and deprecated attributes. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kswedberg what's the word on this one? |
|
Karl said in IRC: "ok, I think if we want to style things based on deprecated/removed status, we can do that with the categories now. so, yeah, we can probably kill that pull request." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #20. It works for this file: https://github.com/jquery/api.jquery.com/blob/master/entries/deferred.isResolved.xml
@kswedberg the fix won't work for any document with a root element and multiple elements. What happens with added/deprecated attributes on that case? Will they land on the root element? We might be able to make that work with the right selector. Otherwise custom fields aren't the right format here.