Build: Update dependencies #81
Conversation
|
|
||
| exports.syntaxHighlight = syntaxHighlight; | ||
|
|
||
| exports.postPreprocessors = { | ||
| _default: function( post, fileName, callback ) { | ||
| _default( post, _fileName, callback ) { |
There was a problem hiding this comment.
Did you add this underscore on purpose?
There was a problem hiding this comment.
Yes, our ESLint config requires all variables & function parameters to be used inside of the function body. For parameters it's not possible in 100% of cases and then prefixing with an underscore is an opt-out.
There was a problem hiding this comment.
We should probably use after-used
There was a problem hiding this comment.
We had a discussion about that some time ago and we decided to use all as there are more cases where we'd leave internal unused parameters than in APIs where they have to be there. This applies especially to AMD module definitions where we've been constantly missing unused dependencies.
We had to prefix some parameters with _ in Core because of this rule but there weren't too many of them.
jQuery
|
.eslintignore
Outdated
| @@ -0,0 +1 @@ | |||
| node_modules/** | |||
There was a problem hiding this comment.
This should be redundant afaik.
There was a problem hiding this comment.
Hmm, I guess I can remove the whole file then.
|
@Krinkle the convention for the not: See https://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines |
This makes all dependencies up to date and switches the project from JSHint to ESLint. That resolves most reported security issues.
A significant number of changes had to be made to
jquery-wp-contentto make it compatible with the new highlight.js; that PR needs to land first.Ref jquery/jquery-wp-content#430