Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Commit

Permalink
Fix for issue #4424 - Transitions with Pages that have Fixed Toolbars…
Browse files Browse the repository at this point in the history 
… - Remove class in class after transition completes
  • Loading branch information
@arschmitz
arschmitz committed Oct 16, 2012
1 parent 7f27938 commit 00a2926
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion js/widgets/fixedToolbar.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,10 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
if ( this._useTransition( notransition ) ) {
$el
.removeClass( "out " + hideClass )
.addClass( "in" );
.addClass( "in" )
.animationComplete(function () {
$el.removeClass('in');
});
}
else {
$el.removeClass( hideClass );
Expand Down

2 comments on commit 00a2926

@johnbender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one appears to be breaking our fixed-toolbar test. Most likely the test just needs to be updated:

http://swarm.jquery.org:8080/job/jQuery%20Mobile%20Phantom%20Master/775/console

@arschmitz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test that's failing explicitly looks for the in class after show which this commit removes. I'm not sure if this class should be there for something else after the animation completes but it dosent seem as though it should. It should only be there durring transition. otherwise this test and the 4th test in this set also which tests for the same thing should be removed. With these tests removed everything runs fine (of course lol)

Please sign in to comment.