New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Box Formatting in Dialog #1618

Closed
jasonparallel opened this Issue May 13, 2011 · 2 comments

Comments

Projects
None yet
4 participants
@jasonparallel

Tested FF win 3.6.17 and chrome win 11.0
Example code - https://github.com/jasonparallel/JQM-Issues/blob/master/SelectInDialog.htm
In FF the select opens correct first - https://github.com/jasonparallel/JQM-Issues/blob/master/SelectInDialog1.jpg
If you click the x to close it and then open it again it opens with off styling - https://github.com/jasonparallel/JQM-Issues/blob/master/SelectInDialog2.jpg
If you were to have selected an option instead of the x the 2nd time you open it it will be styled correctly but hanges when you select a different option.

In chrome it just always has the broken styling.

fiddle example (does the odd styling on the first click in here for some reason) http://jsfiddle.net/jasonparallel/d8wrz/

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 13, 2011

Contributor

We'll give this a look, thanks for the detailed info. In general, it's a good idea to use the native menus in dialogs because things gets messy with the hash. That's a big reason why we switched to defaulting to this globally.

Contributor

toddparker commented May 13, 2011

We'll give this a look, thanks for the detailed info. In general, it's a good idea to use the native menus in dialogs because things gets messy with the hash. That's a big reason why we switched to defaulting to this globally.

@pauln

This comment has been minimized.

Show comment
Hide comment
@pauln

pauln Jun 1, 2011

Contributor

The alternating style seems to be a duplicate of issue #1692, so is addressed by pull request #1750.

The navigation issue caused by opening a dialog from in a dialog is something which really needs to be addressed - though I'm not convinced that it should be treated as a new page (in terms of navigation/history) when opening the select with menuType="page" anyway. I've elaborated on that in issue #1757, so it doesn't get buried within this issue.

Contributor

pauln commented Jun 1, 2011

The alternating style seems to be a duplicate of issue #1692, so is addressed by pull request #1750.

The navigation issue caused by opening a dialog from in a dialog is something which really needs to be addressed - though I'm not convinced that it should be treated as a new page (in terms of navigation/history) when opening the select with menuType="page" anyway. I've elaborated on that in issue #1757, so it doesn't get buried within this issue.

@scottjehl scottjehl closed this in ada4673 Jul 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment