New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url of form is miscalculated #1923

Closed
anho opened this Issue Jun 24, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@anho
Copy link

anho commented Jun 24, 2011

Being on a page with the url 'http://sub.domain.tld/account/login' and having a form-element

<form method="post" id="form_login">

results in a call to '/account/undefined'.

@anho

This comment has been minimized.

Copy link

anho commented Jun 24, 2011

Adding <form action="/account/login"> helps, but gives me http://sub.domain.tld/account/login#/account/login in location bar. Should be http://sub.domain.tld/account/login#/tasks/list because of a redirect.

@jblas

This comment has been minimized.

Copy link
Contributor

jblas commented Jun 24, 2011

@h-andreas

FYI I have a fix for the undefined problem. I'll check it in once I finish writing the unit tests for it.

Regarding your issue with the redirect ... we can't tell when a redirect happens because the browser only calls us back AFTER the redirect has happened so we have no clue that one occurred. That said we've been telling folks to place a data-url="/tasks/list" on their page element in the results.

You can read more about it here:

http://jquerymobile.com/test/#/test/docs/pages/docs-navmodel.html

@ghost ghost assigned jblas Jun 24, 2011

jblas added a commit that referenced this issue Jun 27, 2011

- Fixed issue #1923 - url of form is miscalculated
	- Added code to calculate whether to choose the documentUrl or the page Url in the case where an action is not specified on a form element.

	- Fixed bug in the navigation "submit" handler where an error was being thrown if "type" was not specified.

	- Fixed typo "diabled" id typos in tests/unit/navigation/index.html.

	- Added tests for form submissions with no action in both base and non-base specified cases.
@jblas

This comment has been minimized.

Copy link
Contributor

jblas commented Jun 27, 2011

The fix for the action attribute not being specified has landed on the HEAD:

0d65a0d

@h-andreas

@jblas jblas closed this Jun 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment