enhanceWithin not respecting keepNative in page linked to with data-rel=dialog

[odedbd]

Hi,

The title says it all. I had to modify enhanceWithin to the following in order to get it to work (note the added jqmData(role='dialog') selector to .closest).

        enhanceWithin: function( target ) {
            // TODO remove dependency on the page widget for the keepNative.
            // Currently the keepNative value is defined on the page prototype so
            // the method is as well

            //OBD - if this is a dialog through a data-rel=dialog link, the role will be dialog when we get here...
            var page = $(target).closest(":jqmData(role='page'),:jqmData(role='dialog')").data( "page" ),
            keepNative = (page && page.keepNativeSelector()) || "";

            $( this.options.initSelector, target ).not( keepNative )[ this.widgetName ]();
        }

[odedbd]

looks like eromba@a8c0485 has implemented this fix, and much more (added to tests etc.)

[odedbd]

Oops, seems like the aforementioned commit fixed a similar issue, but in a different place in the code. So this is still open afaik.

[johnbender]

Closed here: 978762d