Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Buttons not disabled in internet explorer #3558
I am trying to disable links with data-role="button".
I have tried this in the html below:
<a href="http://www.bbc.co.uk" data-role="button" class="ui-disabled">BBC</a>
The problems I have are:
Styling issues aside I think the main issue is that "pointer-events: none;" in the ui-disabled style is not standard on anchor tags. My understanding is that it is for use with svg though I may be wrong about that.
and the following styles only included if the browser is IE:
/* IE 8 - Fix to make buttons opaque for disabled /
/* IE 7 - Fix to make buttons opaque for disabled */
Am I doing something wrong in the first place and if not is this a suitable fix?
Is it something you'd be able to incorporate into the core product?
Thanks a lot.
P.S. I have tried with the latest version and I believe it is still an issue.
added a commit
Feb 22, 2012
I have some additional idea how to disable link button in IE. We can render link buttons in ‘buttons’ plugin instead of ‘buttonmarkup’ plugin. In this case we can use disable() and enable() functions for link buttons the same way as for general buttons. All we need is to add [data-role=’button’] to ‘buttons’ plugin initSelector and remove ‘:jqmData(role='button')’ from ‘buttonmarkup’ plugin initSelectior. It works for IE8/9. In this case we will have 'disabled' attribute and also 'ui-disabled' css class. 'disabled' attribute will make the trick to make link unclickable for IE8/9. Unfortunately I found out that this approach doesn’t work for IE7 because it ignores ‘disabled’ attribute and link stays clickable. As a possible workaround we can temporary rename ‘href’ attribute in disabled() func to ‘hrefTemp’ and set it again in enable() func.
Thanks for giving your attention to this issue. Very much appreciated. Is this likely to make it into 1.1?
If you could check this out that would be greatly appreciated.
Thanks for the update Todd. I know that you have had a great deal to do for RC2 but this is somewhat disappointing though considering the statement regarding 1.1 "Our philosophy in 1.1 was to really focus on making the current feature set we had as close to perfect as we could, without sacrificing compatibility." when this is clearly a bug.
Are you able to give any indication as to the intended release date of 1.1.1?
No I haven't. I can look into it next if you'd like.
On Jun 19, 2012, at 9:25 AM, "Ghislain Seguin" email@example.com wrote: